added warning if node is unhealthy #6833
Conversation
|
|
| .then((health) => metrics.beaconHealth.set(health)) | ||
| .then((health) => {metrics.beaconHealth.set(health); | ||
| if(health == 0){ | ||
| this.logger.warn("Node is unhealthy"); |
There was a problem hiding this comment.
this can't be checked here as the getHealth call here will be retried to fallback nodes, meaning this log will only be triggered if all connected nodes are unhealthy which is not what we want as per issue.
Please double check what was noted in the issue, we might have to use the url score tracked in the http client internally to determine if primary node is unhealthy, this also avoids false positives, i.e. a single failed request will not trigger an unhealthy warning.
See also related PR #6415 on how we currently track if primary node is unhealthy in metrics.
There was a problem hiding this comment.
I understood how to solve it , thanks for the info , will be back with the fix .
|
Closed in favor of #6921 |
added warning if node is unhealthy
fixes #6611